Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uppercase method in template #1119

Merged
merged 1 commit into from
Apr 18, 2021
Merged

uppercase method in template #1119

merged 1 commit into from
Apr 18, 2021

Conversation

Rich-Harris
Copy link
Member

just a hunch, but it looks like this matters to cloudflare workers

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts

@vercel
Copy link

vercel bot commented Apr 18, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/sveltejs/kit-demo/BdJuw6JDjFEc7D4DBvm5EYwmXF8p
✅ Preview: https://kit-demo-git-uppercase-method-sveltejs1.vercel.app

@Rich-Harris Rich-Harris merged commit 112d194 into master Apr 18, 2021
@Rich-Harris Rich-Harris deleted the uppercase-method branch April 18, 2021 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant