Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove dependence of create-svelte build on kit build #1001

Merged
merged 2 commits into from
Apr 13, 2021

Conversation

Conduitry
Copy link
Member

@Conduitry Conduitry commented Apr 13, 2021

The automated builds were failing because create-svelte now depended on kit being built first. Rather than building all of kit just for this, I've copied over the tiny utility function which is all that create-svelte really needed.

Closes #1000

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts

@benmccann benmccann merged commit 3802c64 into sveltejs:master Apr 13, 2021
@Conduitry Conduitry deleted the fix-create-svelte-build branch April 13, 2021 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants