fix: generate tsconfig/jsconfig correctly for library option (#9712)

sveltejs · Apr 19, 2023 · edfdb43 · edfdb43
1 parent fccd659
commit edfdb43
Show file tree

Hide file tree

Showing 7 changed files with 10 additions and 5 deletions.
diff --git a/.changeset/strong-bikes-join.md b/.changeset/strong-bikes-join.md
@@ -0,0 +1,5 @@
+---
+'create-svelte': patch
+---
+
+fix: generate tsconfig/jsconfig correctly for library option
diff --git a/packages/create-svelte/bin.js b/packages/create-svelte/bin.js
@@ -63,15 +63,14 @@ const options = await p.group(
  types: () =>
  p.select({
  message: 'Add type checking with TypeScript?',
+ initialValue: /** @type {'checkjs' | 'typescript' | null} */ ('checkjs'),
  options: [
  {
  label: 'Yes, using JavaScript with JSDoc comments',
- // @ts-expect-error :shrug:
  value: 'checkjs'
  },
  {
  label: 'Yes, using TypeScript syntax',
- // @ts-expect-error :shrug:
  value: 'typescript'
  },
  { label: 'No', value: null }

diff --git a/...shared/+libskeleton+checkjs/jsconfig.json → ...shared/+skeletonlib+checkjs/jsconfig.json b/...shared/+libskeleton+checkjs/jsconfig.json → ...shared/+skeletonlib+checkjs/jsconfig.json
diff --git a/...red/+libskeleton+typescript/tsconfig.json → ...red/+skeletonlib+typescript/tsconfig.json b/...red/+libskeleton+typescript/tsconfig.json → ...red/+skeletonlib+typescript/tsconfig.json
diff --git a/...red/+libskeleton-typescript/jsconfig.json → ...red/+skeletonlib-typescript/jsconfig.json b/...red/+libskeleton-typescript/jsconfig.json → ...red/+skeletonlib-typescript/jsconfig.json
diff --git a/packages/create-svelte/tsconfig.json b/packages/create-svelte/tsconfig.json
@@ -3,11 +3,12 @@
  "allowJs": true,
  "checkJs": true,
  "noEmit": true,
- "noImplicitAny": true,
  "target": "esnext",
  "module": "esnext",
  "moduleResolution": "node",
- "allowSyntheticDefaultImports": true
+ "allowSyntheticDefaultImports": true,
+ "strict": true,
+ "skipLibCheck": true
  },
  "include": ["./scripts/**/*", "./index.js", "./bin.js", "./utils.js"]
 }
diff --git a/packages/create-svelte/utils.js b/packages/create-svelte/utils.js
@@ -7,7 +7,7 @@ export function mkdirp(dir) {
  try {
  fs.mkdirSync(dir, { recursive: true });
  } catch (e) {
- if (e.code === 'EEXIST') return;
+ if (/** @type {any} */ (e).code === 'EEXIST') return;
  throw e;
  }
 }