fix: ignore external links when automatically preloading (#8961)

sveltejs · Feb 9, 2023 · 49d2ec6 · 49d2ec6
1 parent ee8066f
commit 49d2ec6
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 10 deletions.
diff --git a/.changeset/six-poems-exist.md b/.changeset/six-poems-exist.md
@@ -0,0 +1,5 @@
+---
+'@sveltejs/kit': patch
+---
+
+fix: ignore external links when automatically preloading
diff --git a/packages/kit/src/runtime/client/client.js b/packages/kit/src/runtime/client/client.js
@@ -221,14 +221,8 @@ export function create_client({ target }) {
  });
  }
 
- /** @param {URL} url */
- async function preload_data(url) {
- const intent = get_navigation_intent(url, false);
-
- if (!intent) {
- throw new Error(`Attempted to preload a URL that does not belong to this app: ${url}`);
- }
-
+ /** @param {import('./types').NavigationIntent} intent */
+ async function preload_data(intent) {
  load_cache = {
  id: intent.id,
  promise: load_route(intent).then((result) => {
@@ -1261,7 +1255,8 @@ export function create_client({ target }) {
 
  if (!options.reload) {
  if (priority <= options.preload_data) {
- preload_data(/** @type {URL} */ (url));
+ const intent = get_navigation_intent(/** @type {URL} */ (url), false);
+ if (intent) preload_data(intent);
  } else if (priority <= options.preload_code) {
  preload_code(get_url_path(/** @type {URL} */ (url)));
  }
@@ -1347,7 +1342,13 @@ export function create_client({ target }) {
 
  preload_data: async (href) => {
  const url = new URL(href, get_base_uri(document));
- await preload_data(url);
+ const intent = get_navigation_intent(url, false);
+
+ if (!intent) {
+ throw new Error(`Attempted to preload a URL that does not belong to this app: ${url}`);
+ }
+
+ await preload_data(intent);
  },
 
  preload_code,