Making methods const where possible #906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
Can you rebase this to get the tests to run again on the new images? |
pshriwise
force-pushed
the
xref-methods-const
branch
from
96e29dd
to
b177469
Compare
All set! |
|
Thanks @pshriwise |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a
constidentifier to the cross-reference methods to translate between entity handle, ID, and index.There are probably other methods that this identifier can be applied to, but I didn't search them all out and figured it made sense to change these for sure.
Motivation and Context
In downstream applications, it would be nice to be able to use
const DagMC*when possible for safety. (see openmc-dev/openmc@37a10fb).Behavior
No change in the behavior of the code here. Just improved practices.