Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to PyNE v0.7.5 #770

Merged
merged 2 commits into from
Jul 23, 2021
Merged

Update to PyNE v0.7.5 #770

merged 2 commits into from
Jul 23, 2021

Conversation

gonuke
Copy link
Member

@gonuke gonuke commented Jul 22, 2021

This updates the SHA for the PyNE submodule to v0.7.5

@gonuke
Copy link
Member Author

gonuke commented Jul 22, 2021

This can wait for #769 so that I don't need to write a news file :)

@bam241
Copy link
Member

bam241 commented Jul 23, 2021

This looks good but need to me rebased.

@gonuke
Copy link
Member Author

gonuke commented Jul 23, 2021

For some reason, this is building images on my repo?

@gonuke
Copy link
Member Author

gonuke commented Jul 23, 2021

For some reason, this is building images on my repo?

(I cancelled it though)

@bam241
Copy link
Member

bam241 commented Jul 23, 2021

For some reason, this is building images on my repo?

I think there is something we are missing here...

@bam241
Copy link
Member

bam241 commented Jul 23, 2021

I guess it depends on what changed are included in the branch when your are pushing it.

if you develop branch is not up to date... you might include change within the detection path...

@bam241
Copy link
Member

bam241 commented Jul 23, 2021

LTGM!
Merging thx @gonuke

@bam241 bam241 merged commit 8dff5ad into svalinn:develop Jul 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants