Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FStrings.jl #181

Merged
merged 3 commits into from
Apr 28, 2020
Merged

Add FStrings.jl #181

merged 3 commits into from
Apr 28, 2020

Conversation

magonser
Copy link
Contributor

Added FStrings.jl

@magonser magonser changed the title Update db.csv Add FStrings.jl Mar 29, 2020
@magonser
Copy link
Contributor Author

Should I have modified the respective Markdown file as well?

@svaksha
Copy link
Owner

svaksha commented Apr 21, 2020

Hi, sorry I missed this notification.
Yes, add the package info in the relevant section in the markdown file, then run the scrape script and commit locally, remote, and add to this PR. Thanks
PS: I made a few changes, so a 'git pull' is always the best start after committing/stashing local changes.

@magonser
Copy link
Contributor Author

Hi @svaksha ,

thanks for your answer and no problem. After syncing the latest changing from your repo, I have updated the information in API.md and run src/scrape.jl. However looking at the current diff of this PR, it seems that the db.csv has also been updated w.r.t. some other packages. Is this a problem? I could remove the relevant entries manually...

@svaksha
Copy link
Owner

svaksha commented Apr 28, 2020 via email

@svaksha svaksha merged commit 69e1eef into svaksha:master Apr 28, 2020
@magonser
Copy link
Contributor Author

Ok - thank you for the explanation. I see that you have merged it - thank you for your support again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants