-
Notifications
You must be signed in to change notification settings - Fork 514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
assertion failed: (duk_size_t) a_size <= DUK_HOBJECT_MAX_PROPERTIES in duk__get_min_grow_a #2023
Labels
Comments
Thanks @renatahodovan, I'll check this out. |
svaarala
added a commit
that referenced
this issue
Jul 15, 2019
* Add bug testcase for GH-2023. * Testcase coverage improvement for Object.defineProperty() and array part handling.
svaarala
added a commit
that referenced
this issue
Jul 15, 2019
When array size is limited to 16 bits, some internal operations which don't support abandoning the array could try to grow it beyond 16 bits rather than abandoning the array part. This caused an assertion failure and also potentially memory unsafe behavior. Changes: * When growing the property table, sanity check entry and array sizes. If the new values won't fit in the duk_hobject structure (which may happen with 16-bit fields), fail the grow attempt with an internal error. This avoids field truncation and potentially memory unsafe behavior as a result. * Rework array part growth vs. abandon code to avoid the GH-2023 issue. * Add support for keeping array part when possible into Object.defineProperty(). * Add support for abandoning array part when using internal variants for defining properties (such as in Array .map()). * Executor compile warning fix. * Debug logging trivia, downgrade a noisy log entry. * Fix compile warning in duk_cmdline.c.
svaarala
added a commit
that referenced
this issue
Jul 15, 2019
svaarala
added a commit
that referenced
this issue
Jul 16, 2019
Array handling improvements, fix GH-2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Duktape version:
OS:
Test case:
Backtrace:
Found by Fuzzinator with grammarinator.
The text was updated successfully, but these errors were encountered: