Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove logging while collecting GPU metrics #1460

Merged
merged 1 commit into from
May 21, 2024

Conversation

vprashar2929
Copy link
Collaborator

@vprashar2929 vprashar2929 commented May 21, 2024

removes debugging logging from GPU metrics

@vprashar2929
Copy link
Collaborator Author

cc: @dave-tucker

Copy link

github-actions bot commented May 21, 2024

🤖 SeineSailor

Here is a concise summary of the pull request changes:

Summary: Refactor logging in CollectResUtilizationMetrics function in pkg/metrics/utils/utils.go.

Key Modifications:

  • Initially, logging level was updated to klog.V(5).Info for more detailed logging when verbose level is 5 or above.
  • Later, the logging statement was removed to reduce unnecessary output.

Impact: These changes only affect logging behavior, without altering the function's signature, global data structures, or external interface.

Observations: The changes seem to be a revert of the initial logging update, suggesting that the more detailed logging was deemed unnecessary. It's essential to ensure that logging levels are properly configured to balance verbosity and performance.

Copy link
Collaborator

@dave-tucker dave-tucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The line can also be removed entirely - it was left over from debugging and I'd forgotten to remove it.

@vprashar2929
Copy link
Collaborator Author

Ah in that case I am happy to remove it as well

removes debugging logging from GPU metrics

Signed-off-by: Vibhu Prashar <[email protected]>
@vprashar2929 vprashar2929 changed the title fix: add verbose level while collecting GPU metrics fix: remove logging while collecting GPU metrics May 21, 2024
@vprashar2929
Copy link
Collaborator Author

cc: @rootfs

@@ -57,7 +57,6 @@ func CollectResUtilizationMetrics(ch chan<- prometheus.Metric, instance interfac
CollectResUtil(ch, instance, collectorName, collectors[collectorName])
}
}
klog.Info("Collecting GPU metrics")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may want to log this somewhere at V(5) or so probably inside the if

@sthaha sthaha merged commit bfd621a into sustainable-computing-io:main May 21, 2024
27 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants