Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add different font style for docs sidebar headers #1896

Merged
merged 1 commit into from
Jun 10, 2021
Merged

Add different font style for docs sidebar headers #1896

merged 1 commit into from
Jun 10, 2021

Conversation

marcelscruz
Copy link
Contributor

@marcelscruz marcelscruz commented Jun 9, 2021

What kind of change does this PR introduce?

A style change on the headers of the docs sidebar, to improve the distinction from the link items.

What is the current behavior?

The current sidebar headers on the docs are similar to link items, only differentiated by a lower-opacity colour and more spacing, possibly making someone think of it as a disabled link.

What is the new behavior?

Proposed headers are more distinct from the links, with bolder and uppercase letters, for easier scannability and better hierarchy cue.

Additional context

This is a totally unrequested change to the style, which also might diverge from the brand styling, so I understand if this is not accepted.

And here's a quick overview of the new look.

sidebar comparison

@vercel
Copy link

vercel bot commented Jun 9, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

nextjs-todo-list – ./examples/nextjs-todo-list

🔍 Inspect: https://vercel.com/supabase/nextjs-todo-list/qJseVivHTtVD9JwkkSam31wbnK3z
✅ Preview: Canceled

main – ./

🔍 Inspect: https://vercel.com/supabase/main/9rD6hM33psXyRxXXUoxeGHW16QVo
✅ Preview: https://main-git-fork-marcelscruz-style-general-supabase.vercel.app

docs – ./web

🔍 Inspect: https://vercel.com/supabase/docs/A9P3TDqukWyW9L9vzenSPRy2DSwi
✅ Preview: https://docs-git-fork-marcelscruz-style-general-supabase.vercel.app

www – ./www

🔍 Inspect: https://vercel.com/supabase/www/8tfxQ8Unnoo4W4jkqyX7qwGPaPZq
✅ Preview: Canceled

@kiwicopple
Copy link
Member

This is a totally unrequested change to the style, which also might diverge from the brand styling, so I understand if this is not accepted.

Really appreciate the PR @marcelscruz - helps for us to see it in a branch and make a judgement. I'll review a bit later tonight!

@kiwicopple
Copy link
Member

@marcelscruz - this is awesome, thanks for the improvement. If you want you can send a link to this PR to [email protected] with you tshirt size and postal address for some free swag :)

@MildTomato - FYI in case you want to improve after I have merged

@kiwicopple kiwicopple merged commit a9623b7 into supabase:master Jun 10, 2021
@marcelscruz
Copy link
Contributor Author

@kiwicopple That's awesome, I'm already happy by seeing my contribution live in the docs, and having some swag makes it even better. Thank you!

BTW, UI-related tasks are my favourite, so if you have some open, I'd love to give them a go.

Also, I want to take the opportunity to say that this project is amazing!
I'm about to start migrating devresourc.es to Supabase, just need to find out how to migrate the auth users. I'll let the community know once it's ready.

Have a nice day!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants