Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add verify token hash #722

Merged
merged 1 commit into from
Jul 18, 2023
Merged

fix: add verify token hash #722

merged 1 commit into from
Jul 18, 2023

Conversation

kangmingtay
Copy link
Member

@kangmingtay kangmingtay commented Jul 5, 2023

What kind of change does this PR introduce?

@imbhargav5
Copy link

So happy to see this!

@kangmingtay kangmingtay merged commit 293662c into master Jul 18, 2023
@kangmingtay kangmingtay deleted the km/add-verify-token-hash branch July 18, 2023 23:38
@github-actions
Copy link
Contributor

🎉 This PR is included in version 2.44.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@MitjaBezensek
Copy link

Did this really fix #694? For me it still looks broken.

@silentworks
Copy link
Contributor

@MitjaBezensek yes it fixes it, but I need to document how to use this for it to work.

@elbracht
Copy link

@silentworks i would find a short explanation / documentation how to use generateLink with PKCE really fantastic 👏

@wyozi
Copy link

wyozi commented Sep 2, 2023

@elbracht I wrote a short blog post on this: https://catjam.fi/articles/supabase-generatelink-fix

@kgrady13
Copy link

kgrady13 commented Oct 4, 2023

@elbracht I wrote a short blog post on this: https://catjam.fi/articles/supabase-generatelink-fix

I sincerely appreciate your blog post 🍻

@yuvalkarmi
Copy link

@elbracht thanks for making it so easy and clear! Love this.
By the way, it looks like you first refer to the link response by the variable linkResponse and in the last code snippet by the variable l (and disregard your earlier tokenHash variable). Just a heads up :)

@amitduaaa
Copy link

@wyozi I followed your blog to implement something similar but it gives AuthApiError: Email link is invalid or has expired.

https://localhost:3000/api/auth/callback?token_hash=<token_hash>&next=%2Foverview

I create this link and then user clicks on it, gets redirected to /api/auth/callback where I try to verifyOTP using this token_hash but it gives me the mentioned error.

@scottklein7
Copy link

@amitduaaa I get this error too, what was your fix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

auth.admin.generateLink not working with PKCE