-
-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add verify token hash #722
Conversation
So happy to see this! |
3a9603d
to
4bd5e03
Compare
🎉 This PR is included in version 2.44.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Did this really fix #694? For me it still looks broken. |
@MitjaBezensek yes it fixes it, but I need to document how to use this for it to work. |
@silentworks i would find a short explanation / documentation how to use generateLink with PKCE really fantastic 👏 |
@elbracht I wrote a short blog post on this: https://catjam.fi/articles/supabase-generatelink-fix |
I sincerely appreciate your blog post 🍻 |
@elbracht thanks for making it so easy and clear! Love this. |
@wyozi I followed your blog to implement something similar but it gives AuthApiError: Email link is invalid or has expired. https://localhost:3000/api/auth/callback?token_hash=<token_hash>&next=%2Foverview I create this link and then user clicks on it, gets redirected to /api/auth/callback where I try to verifyOTP using this token_hash but it gives me the mentioned error. |
@amitduaaa I get this error too, what was your fix? |
What kind of change does this PR introduce?
token_hash
andtype
inverifyOtp
methodPOST /verify
to accept a token hash auth#1165auth.admin.generateLink
not working with PKCE #694