-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add JMH based benchmarks #8
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM except a few minor comments!
@@ -19,9 +19,11 @@ allprojects { | |||
arrowVersion = "0.14.1" | |||
parquetVersion = "1.10.1" | |||
hiveVersion = "2.3.4" | |||
prestoHiveShadedVersion = "2.3.4-1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm. Why we need to add the Presto Hive dependency here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Presto has Hive exec shaded and avoids major headache with version conflicts.
pegasus-parquet/src/test/java/com/uber/pegasus/parquet/BenchmarkParquetReader.java
Outdated
Show resolved
Hide resolved
Also: * ColumnReaderFactory to create ColumnReader and ValueVector * fix invalid readSize issue in AbstractColumnReader
`gradle jmh` to execute benchmark tests. Disabled the benchmarks for types that are not yet implemented
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! you'll need to rebase and reformat.
No description provided.