Fix illegal pointer reference in LookupKey #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the LookupKey struct we currently allocate fixed length array on stack if the key size is small enough, and then store the pointer to the array. This, however, will fail since later on the array will be moved to an new address, but the pointer is still referring to the old memory location! It seems dangerous to operate on the pointer in this case. This commit changes LookupKey to allocate the array on heap in all cases. We shall see how the performance impact of this is, and come back later if necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the LookupKey struct we currently allocate fixed length array on
stack if the key size is small enough, and then store the pointer to the
array. This, however, will fail since later on the array will be moved
to an new address, but the pointer is still referring to the old memory
location!
It seems dangerous to operate on the pointer in this case. This commit
changes LookupKey to allocate the array on heap in all cases. We shall
see how the performance impact of this is, and come back later if
necessary.