Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the function groebner_with_change_matrix #131

Merged
merged 3 commits into from
Mar 14, 2024
Merged

Conversation

sumiya11
Copy link
Owner

To compute a (non-unique) standard representation of the Groebner basis with respect to the initial generators of the ideal.

It computes a (non-unique) standard representation of the basis
with respect to the initial generators of the ideal.

The computation mirrors the standard F4,
but also keeps track of row operations in the F4 matrix.

The standard representations are eagerly updated,
which may hurt performance a bit.

Works for AA and Nemo, not tested for DynamicPolynomials.jl
Copy link

codecov bot commented Mar 14, 2024

Codecov Report

Attention: Patch coverage is 93.93443% with 37 lines in your changes are missing coverage. Please review.

Project coverage is 80.46%. Comparing base (7051acc) to head (2f9d9e7).

Files Patch % Lines
src/groebner/groebner_with_change_matrix.jl 89.09% 18 Missing ⚠️
src/f4/linalg/backend_changematrix.jl 95.03% 8 Missing ⚠️
src/f4/basis.jl 93.68% 6 Missing ⚠️
src/f4/linalg/backend.jl 66.66% 2 Missing ⚠️
src/fglm/fglm_internal.jl 50.00% 1 Missing ⚠️
src/groebner/learn-apply.jl 50.00% 1 Missing ⚠️
src/utils/keywords.jl 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #131      +/-   ##
==========================================
+ Coverage   79.62%   80.46%   +0.83%     
==========================================
  Files          58       60       +2     
  Lines        7609     8145     +536     
==========================================
+ Hits         6059     6554     +495     
- Misses       1550     1591      +41     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sumiya11 sumiya11 merged commit f11c153 into master Mar 14, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant