Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pointer instead of unsafe_convert #126

Merged
merged 1 commit into from
Feb 27, 2024
Merged

Conversation

yuyichao
Copy link
Contributor

This fixes the error due to the Base memory buffer change (the cconvert for Arrays returns MemoryRef now and the unsafe_convert takes in MemoryRef rather than Array accordingly).

Adding cconvert would also work but since the input type is know it's not necessary to do that.

Copy link

codecov bot commented Feb 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.56%. Comparing base (36dffb7) to head (81a0e60).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #126   +/-   ##
=======================================
  Coverage   79.56%   79.56%           
=======================================
  Files          58       58           
  Lines        7614     7614           
=======================================
  Hits         6058     6058           
  Misses       1556     1556           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sumiya11
Copy link
Owner

Thanks for the PR! As far as I recall, I used unsafe_convert over pointer since the former seemed a bit faster. But now I see that one just calls another in this case, so perhaps I was mistaken.

@sumiya11 sumiya11 merged commit f076974 into sumiya11:master Feb 27, 2024
12 of 13 checks passed
@yuyichao yuyichao deleted the pointer branch February 27, 2024 21:51
@KristofferC
Copy link

A new version with this would be nice (if possible).

@sumiya11
Copy link
Owner

sumiya11 commented Mar 4, 2024

Sure; done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants