Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If it show result, it should be to show QR code after modal. #3

Closed
mint73 opened this issue Nov 25, 2023 · 8 comments
Closed

If it show result, it should be to show QR code after modal. #3

mint73 opened this issue Nov 25, 2023 · 8 comments
Labels
enhancement New feature or request
Milestone
Backlog

Comments

@mint73
Copy link
Member

mint73 commented Nov 25, 2023

To show QR Code takes long time (about one second).
Some customer may be think that this application is broken.
So, it showld show modal before make QR code.
@mint73 mint73 added the enhancement New feature or request label Nov 27, 2023
@mint73 mint73 added this to the 2024 GA milestone Nov 27, 2023
@mint73 mint73 self-assigned this Nov 27, 2023
@mint73
Copy link
Member Author

mint73 commented Dec 8, 2023

To use async/await

mint73 added a commit that referenced this issue Dec 19, 2023
@mint73
#3 Fixed
8a885c3
mint73 added a commit that referenced this issue Dec 19, 2023
@mint73
Merge pull request #8 from mint73/mint73/issue3
2dad53e 
#3 Fixed
@mint73
Copy link
Member Author

mint73 commented Dec 19, 2023

Fixed but, a part...

@mint73
Copy link
Member Author

mint73 commented Dec 25, 2023

How about to use AOT compilation?

@mint73
Copy link
Member Author

mint73 commented Jan 24, 2024

Change the button message or...

@mint73
Copy link
Member Author

mint73 commented Jan 29, 2024 •
edited
Loading

Show the Loading icon after putting the button.

@mint73
Copy link
Member Author

mint73 commented May 9, 2024

Umm...

This problem is not a big issue, so I decided to leave the problem alone

@mint73 mint73 closed this as completed May 9, 2024
@mint73 mint73 reopened this May 9, 2024
@mint73 mint73 modified the milestones: 2024 GA, Backlog May 9, 2024
@mint73 mint73 removed their assignment May 27, 2024
@mint73
Copy link
Member Author

mint73 commented Jun 2, 2024

(QR コードボタンのモーダル表示に時間がかかるという問題。 QR コードが生成されてからモーダルの表示をしているので、モーダルを表示してから、 QR コードを生成 (生成する前は読み込み中のアイコンを表示) にすることで、 UX を向上できるという案。だが、なんか難しそう)

@mint73
Copy link
Member Author

mint73 commented Jul 2, 2024

#63 によってパフォーマンスが異常に上がったので、これの必要がなくなったので Close します。

@mint73 mint73 closed this as completed Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
1 participant
@mint73