add feed_url property #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The W3C feed validator recommends adding an atom:link tag with the URL of the feed itself. This adds a feed_url property to Channel which is used in an atom:link tag.
|
@christianp Thank you for sending great proposal! I'd like to merge your work. We prefer camel case method names and variable names rather thank snake case. I know it is very small issue, but naming consistency makes people who use this library less confusing. Could you fix the |
|
Happy to oblige :) |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The W3C feed validator recommends adding an atom:link tag with the URL
of the feed itself.
This adds a feed_url property to Channel which is used in an atom:link
tag.