Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

makefile handles bindata dependency #166

Merged
merged 2 commits into from
Jun 3, 2021
Merged

makefile handles bindata dependency #166

merged 2 commits into from
Jun 3, 2021

Conversation

audibleblink
Copy link

@audibleblink audibleblink commented May 1, 2021 •
edited
Loading

to:
cc: @subspacecommunity/subspace-maintainers
related to:
resolves:

Background

I was running into chicken and egg issues when building with build: . in docker-compose

Changes

  • Use Make's target dependencies

Testing

make build

@sonarcloud
Copy link

sonarcloud bot commented May 1, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

agonbar
agonbar approved these changes Jun 3, 2021
View reviewed changes
Copy link
Collaborator

@agonbar agonbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Certainly a good improvement, more clean, pun intended.

@sonarcloud
Copy link

sonarcloud bot commented Jun 3, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@agonbar agonbar merged commit 405046d into subspacecommunity:master Jun 3, 2021
@agonbar
Copy link
Collaborator

agonbar commented Jun 3, 2021

@all-contributors please add @audibleblink for code

@allcontributors allcontributors bot mentioned this pull request Jun 3, 2021
Merged
@allcontributors
Copy link

@agonbar

I've put up a pull request to add @audibleblink! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agonbar agonbar agonbar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@audibleblink @agonbar