Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The 1.5.0 Docker tag is the same as 1.3 #193

Open
syphernl opened this issue Jun 15, 2021 · 5 comments
Open

The 1.5.0 Docker tag is the same as 1.3 #193

syphernl opened this issue Jun 15, 2021 · 5 comments
Labels
bug Something isn't working

Comments

@syphernl
Copy link

Describe the bug
After upgrading to 1.5.0 (image: subspacecommunity/subspace:1.5.0), which should contain TOTP settings, I am not seeing anything new.
No TOTP is being shown for the "local" admin account nor the one authenticated through SAML.

Digging through the code of the commit (#126) I see there also should be an /totp/image endpoint but this is returning 404 page not found.

To Reproduce
Steps to reproduce the behavior:

  1. Run subspacecommunity/subspace:1.5.0
  2. Login, go to settings
  3. No TOTP settings shown
@gchamon
Copy link

gchamon commented Jun 15, 2021

I can confirm that pulling from dockerhub results in totp not being enabled. However, cloning and compiling subspace from source shows that the feature is indeed in the master branch... curious

@agonbar do you have any idea what could have gone wrong with the dockerhub integration?

image

A check fails, but I don't have access to dockerhub so I cant really see what went wrong. However the image was updated succesfully, at least for x86_64 devices, so I don't know where to start looking for a flaw.

I wonder if triggering another release would cause the image to be updated with the correct code, but I don't want to play around with productive assets.

@syphernl in the meantime you can compile the master branch. That will provide you the correct code until I can find what went wrong with publishing the docker image.

@gchamon gchamon added the bug Something isn't working label Jun 15, 2021
@gchamon
Copy link

gchamon commented Jun 15, 2021

@agonbar Indeed as pointed out by Elbert Lai in slack, dockerhub is pulling an old hash
image
image

both have the same hashes

@gchamon
Copy link

gchamon commented Jun 15, 2021

@syphernl just found out that the tag amd64-v1.5.0 is working as intended. Please use that until we fix and update the shorthand tags

@syphernl syphernl changed the title TOTP settings not visible in interface The 1.5.0 Docker tag is the same as 1.4 Jun 16, 2021
@gchamon gchamon changed the title The 1.5.0 Docker tag is the same as 1.4 The 1.5.0 Docker tag is the same as 1.3 Jun 16, 2021
gchamon added a commit that referenced this issue Aug 8, 2021
I have to put a notice for the busted dockerhub tags. Follows #193
@dawidmachon
Copy link

It is fixed?

@mrnonz
Copy link

mrnonz commented Nov 10, 2021

@syphernl just found out that the tag amd64-v1.5.0 is working as intended. Please use that until we fix and update the shorthand tags

Any update on docker tag issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants