Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore cleanup turbo functions #2176

Merged
merged 11 commits into from
Feb 16, 2024
Merged

Chore cleanup turbo functions #2176

merged 11 commits into from
Feb 16, 2024

Conversation

EvertBunschoten
Copy link
Member

@EvertBunschoten EvertBunschoten commented Nov 24, 2023 •
edited

Proposed Changes

Cleaned up the Riemann boundary condition in CEulerSolver

Related Work

PR Checklist

Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.

  • I am submitting my contribution to the develop branch.
  • My contribution generates no new compiler warnings (try with --warnlevel=3 when using meson).
  • My contribution is commented and consistent with SU2 style (https://su2code.github.io/docs_v7/Style-Guide/).
  • I used the pre-commit hook to prevent dirty commits and used pre-commit run --all to format old commits.
  • I have added a test case that demonstrates my contribution, if necessary.
  • I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp), if necessary.

@EvertBunschoten EvertBunschoten self-assigned this Nov 24, 2023
@bigfooted bigfooted changed the base branch from master to develop November 24, 2023 12:42
github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 5, 2023
View reviewed changes
SU2_CFD/src/solvers/CEulerSolver.cpp
while ( iter <= maxiter ) {

density_mix = val_Averaged_Flux[0]*val_Averaged_Flux[0]/(val_Averaged_Flux[1] - pressure_mix);
const su2double density_mix = val_Averaged_Flux[0]*val_Averaged_Flux[0]/(val_Averaged_Flux[1] - pressure_mix);

Check notice

Code scanning / CodeQL

Declaration hides parameter Note

Local variable 'density_mix' hides a
parameter of the same name
.
@pcarruscag
Copy link
Member

@joshkellyjak please review this PR when you have a sec

@EvertBunschoten EvertBunschoten marked this pull request as ready for review February 13, 2024 19:41
@EvertBunschoten EvertBunschoten changed the title [WIP]Chore cleanup turbo functions Chore cleanup turbo functions Feb 16, 2024
joshkellyjak
joshkellyjak approved these changes Feb 16, 2024
View reviewed changes
Copy link
Contributor

@joshkellyjak joshkellyjak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@EvertBunschoten EvertBunschoten merged commit f7c27cd into develop Feb 16, 2024
30 of 31 checks passed
@EvertBunschoten EvertBunschoten deleted the chore_cleanup_turbo_functions branch February 16, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshkellyjak joshkellyjak joshkellyjak approved these changes

Assignees

@EvertBunschoten EvertBunschoten

Labels
changelog:chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@EvertBunschoten @pcarruscag @joshkellyjak