Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade npm to 6.x #164

Merged
merged 2 commits into from
Oct 15, 2018
Merged

Upgrade npm to 6.x #164

merged 2 commits into from
Oct 15, 2018

Conversation

styfle
Copy link
Owner

@styfle styfle commented Oct 15, 2018

This might not be backwards compatible so I need to do some testing.
I am also upgrading the database to be able to handle more data.
Hopefully now v2 will help with the load.

@vercel
Copy link

vercel bot commented Oct 15, 2018

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

@styfle
Copy link
Owner Author

styfle commented Oct 15, 2018

Now v2 doesn't work at this time since the built image is over 100MB 😢

I'll have to revisit that in the future.

For the time being, this will be good to bump npm version 👍

@styfle styfle merged commit c9da1a8 into master Oct 15, 2018
@styfle styfle deleted the upgrade-npm branch October 15, 2018 01:30
styfle added a commit that referenced this pull request Dec 1, 2023
Back when Package Phobia first came out in 2018, it used `npm@5` to
install dependencies and measure the size. That was later upgrade to
[npm@6](#164) with little
behavior changed.

Then upgrading node caused problems with the old version of npm so
Package Phobia switched to
[yarn@2](#959) and later
[yarn@3](#976) which both
omit peer dependencies by default.

Recently, Package Phobia switched to
[npm@10](#1021) which will
automatically install peer dependencies.

This PR will change the behavior back to omit peer dependencies.

- Fixes #1025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant