Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid matching in a word in is_write_query() #95

Merged
merged 2 commits into from
Nov 21, 2020

Conversation

takotakot
Copy link
Contributor

No description provided.

@JJJ
Copy link
Collaborator

JJJ commented Apr 30, 2020

@spacedmonkey just going through PRs. Any more thoughts on this one?

We really need to get unit tests setup and working. Wanna take that on, too?

@spacedmonkey
Copy link
Collaborator

I don’t want to merge this without unit test. I will add unit tests to ci in another pr

@JJJ
Copy link
Collaborator

JJJ commented Apr 30, 2020

@spacedmonkey understandable. I did just merge #100 which is going to conflict with this PR. Sorry about that.

@amitaymolko
Copy link

On master:
is_write_query("SELECT option_name, option_value FROM wp_options WHERE autoload = 'yes'");
returns true.
With this fix, it returns false

@JJJ
Copy link
Collaborator

JJJ commented Nov 16, 2020

@amitaymolko That's a good thing!

@amitaymolko
Copy link

@JJJ
Yeah, the fix is good, it reduces the load on the write servers.

@JJJ JJJ merged commit dc3167b into stuttter:master Nov 21, 2020
@JJJ
Copy link
Collaborator

JJJ commented Nov 21, 2020

Merged to master. This is working fine for me, too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants