Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix misleaded property definitions #476

Merged
merged 1 commit into from
Nov 1, 2019
Merged

Fix misleaded property definitions #476

merged 1 commit into from
Nov 1, 2019

Conversation

pure180
Copy link
Contributor

@pure180 pure180 commented Oct 11, 2019

Fixes wrong type definitions in documentation for the arguments of SharedMethod and SharedMethod.fromFunction.

Fixes #462

  • npm test passes on your machine
  • Code conforms with the style guide
  • Commit messages are following our guidelines
  • Not necessary - New tests added or existing tests modified to cover all changes

@slnode
Copy link

slnode commented Oct 11, 2019

Can one of the admins verify this patch? To accept patch and trigger a build add comment ".ok\W+to\W+test."

@bajtos
Copy link
Member

bajtos commented Oct 11, 2019

@slnode ok to test

@bajtos bajtos added community-contribution Patches contributed by community doc labels Oct 11, 2019
bajtos
bajtos approved these changes Oct 11, 2019
View reviewed changes
Copy link
Member

@bajtos bajtos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely, thank you @pure180 for the contribution! ❤️

Let's wait for CI results before merging.

@bajtos bajtos merged commit 1f5abde into strongloop:master Nov 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bajtos bajtos bajtos approved these changes

@agnes512 agnes512 agnes512 approved these changes

@clark0x clark0x Awaiting requested review from clark0x

@ebarault ebarault Awaiting requested review from ebarault ebarault is a code owner

@fabien fabien Awaiting requested review from fabien fabien is a code owner

@ritch ritch Awaiting requested review from ritch ritch is a code owner

@superkhau superkhau Awaiting requested review from superkhau

@zbarbuto zbarbuto Awaiting requested review from zbarbuto zbarbuto is a code owner

Assignees
No one assigned
Labels
community-contribution Patches contributed by community doc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Possibly wrong @property definitions in documentation?
4 participants
@pure180 @slnode @bajtos @agnes512