Fix handling of anonymous object types #472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bajtos
requested review from
clark0x,
ebarault,
fabien,
ritch,
superkhau and
zbarbuto
as code owners
hacksparrow
approved these changes
Oct 4, 2019
jannyHou
reviewed
Oct 4, 2019
jannyHou
approved these changes
Oct 4, 2019
In LoopBack, the method `PersistedModel.updateAll` describes the return
type using an inline (anonymous) definition:
returns: {
arg: 'info',
type: {
count: {
type: 'number',
description: 'The number of instances updated',
},
},
root: true,
},
Before this change, remote invocation of updateAll was crashing the
process with the following error:
AssertionError: type must be either an array or a string.
This commit fixes the problem as follows:
- A try/catch block is introduced to correctly report any sync errors
via the callback
- The type registry was improved to recognize anonymous object types
and use the "object" converter for them.
Signed-off-by: Miroslav Bajtoš <[email protected]>
bajtos
force-pushed
the
fix/loopback-remote-invoke-updateAll
branch
from
d2872ac
to
d60b69b
Compare
delete-merged-branch
bot
deleted the
fix/loopback-remote-invoke-updateAll
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In LoopBack, the method
PersistedModel.updateAlldescribes the return type using an inline (anonymous) definition:Before this change, remote invocation of updateAll was crashing the process with the following error:
This patch fixes the problem as follows:
A try/catch block is introduced to correctly report any sync errors via the callback
The type registry was improved to recognize anonymous object types and use the "object" converter for them.
Related issues
Fixes strongloop/loopback#3717
/cc @angfal @ewrayjohnson
Checklist