Fixate event-stream version to 3.3.1 #458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bajtos
requested review from
clark0x,
ebarault,
fabien,
ritch,
superkhau and
zbarbuto
as code owners
b-admike
approved these changes
Nov 27, 2018
jannyHou
approved these changes
Nov 27, 2018
There was a problem hiding this comment.
Good catch! 👍
The latest safe version is 3.3.4 according to https://snyk.io/blog/malicious-code-found-in-npm-package-event-stream (the last paragraph mentions that)
And event-stream released a new major version(4.x) to remove the malicious package. Let's merge this PR first then I can try upgrade event-stream to 4.x.
|
Will this also be back-ported to 2.x? |
|
@zbarbuto good catch! Would you mind back-porting the change yourself? |
|
Sure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://snyk.io/blog/malicious-code-found-in-npm-package-event-stream