Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deleteType support in loopback 2.x #454

Merged
merged 1 commit into from
Sep 6, 2018
Merged

deleteType support in loopback 2.x #454

merged 1 commit into from
Sep 6, 2018

Conversation

snarjuna
Copy link

@snarjuna snarjuna commented Sep 6, 2018

Description

deleteType to remove type from existing types. This is equivalent to deleteType for typeRegistry which exist in loopback 2.x

Related issues

Checklist

  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style
    guide

@slnode
Copy link

slnode commented Sep 6, 2018

Can one of the admins verify this patch? To accept patch and trigger a build add comment ".ok\W+to\W+test."

@snarjuna snarjuna changed the title Implemented deleteType to remove type from existing types deleteType support in loopback 2.x Sep 6, 2018
@snarjuna
Copy link
Author

snarjuna commented Sep 6, 2018

@bajtos As per our discussion, I have created a PR to support delete types. Please review and merge

@bajtos
Copy link
Member

bajtos commented Sep 6, 2018

thank you @snarjuna for the pull request! The changes look good, let's fix the CI checks now.

commits in this PR have formatting problems

Our commit message conventions are described here: https://loopback.io/doc/en/contrib/git-commit-messages.html Most importantly, we use imperative form instead of past tense.

While you are making those changes, please squash both commits into single one (git rebase -i master && git push -f).

One or more of this commit's parents has contributors who have not signed the Contributor License Agreement.

Please sign the CLA here:
https://cla.strongloop.com/agreements/strongloop/strong-remoting

Unfortunately, this step is required from IBMers too.

@snarjuna
Copy link
Author

snarjuna commented Sep 6, 2018

@bajtos I have resolved your comments. Can you please merge now

@bajtos bajtos merged commit 9d6edbd into strongloop:2.x Sep 6, 2018
@bajtos
Copy link
Member

bajtos commented Sep 6, 2018

Landed. 🎉 Thank you for the contribution! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants