Fix ignored facilities #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure that something silly doesn't happen, like toFacility(0) doing a reverse lookup and returning 'LOG_KERN' instead of a number.
Fix a bug in toFacility that resulted in toFacility(0) returning the string 'LOG_KERN' (a reverse lookup). Because toFacility is used by syslog.open() this was resulting in all numeric (aka, pre-resolved) log facilities being mapped to a string which always converted to 0. This should fix the problem reported in #8 and first discovered in baudehlo/Haraka#1145
|
👍 thanks greatly for your effort in tracking that down. |
|
I just tested that patch against my production Haraka and it does indeed solve the problem. |
|
👍 now it also runtastic 💯 on docker image. Thanks Ryan. Can only agree with Matt. |
|
LGTM, can you publish after merge? |
|
Released [email protected] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe this to be the root of #8. The problem isn't specific to FreeBSD, but the fact that Haraka was using
syslog.open()to specify a log facility by number (syslog.LOG_MAILinstead of'LOG_MAIL').It's a pretty trivial change, so we should be able to publish a patch release shortly.
@sam-github PTAL
/cc @Dexus @msimerson
Connect to #8