compatiblity: expose LOG_ properties globally #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rmg this doesn't appear to be in CI, but it was added in https://github.com/strongloop-internal/ci-infrastructure/pull/7/files PTAL |
| @@ -18,5 +18,8 @@ tap.test(function(t) { | |||
| t.doesNotThrow(function() { | |||
| Syslog.close(); | |||
| }, 'Syslog.close'); | |||
| t.assert('LOG_KERN' in Syslog, 'facilities are global for compat'); | |||
There was a problem hiding this comment.
Should this also be asserting that it is equal to the other location?
|
Couple minor nits. Nothing blocking if you are in a hurry, so LGTM. |
Undocumented, but exposed like this for compatability with node-syslog.
f631ab8
to
2e252d6
Compare
sam-github
added a commit
that referenced
this pull request
Sep 2, 2015
compatiblity: expose LOG_ properties globally
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Undocumented, but exposed like this for compatability with node-syslog.
connected to connected to strongloop-internal/scrum-nodeops#893
see https://github.com/strongloop-internal/scrum-nodeops/issues/893#issuecomment-136826046