Update nan version #13
Conversation
Supports nodev6
|
Can one of the admins verify this patch? To accept patch and trigger a build add comment ".ok\W+to\W+test." |
| @@ -24,7 +24,7 @@ | |||
| "tap": "^1.3.2" | |||
| }, | |||
| "dependencies": { | |||
| "nan": "^2.0.5" | |||
| "nan": "^2.3.5" | |||
There was a problem hiding this comment.
This has no purpose, we don't depend on any feature added in 2.3, and npm will always install the latest matching, and ^2.0.5 matches 2.3.5, so it will get installed.
Why did you think this necessary?
There was a problem hiding this comment.
I am not well versed in semver, and double checking the docs confirms that ^2.0.5 matches 2.3.5. However, trying to build on node v6.2.1 and npm 3.9.6, I get the errors shown in #14. Upgrading nan to 2.3.5 in the package.json fixes the issue. Is there something else I am missing?
There was a problem hiding this comment.
yes, what you probably noticed is that npm install does not update dependencies. so if you had previously installed, had an old nan, then installed again, nan would not be updated. then, I bet you did something like npm install --save nan or something of the like, and that caused it to update nan, and also update the package.json. the latter was irrelevant, the nan update was what helped you.
Anyhow, do this: rm -rf node_modules; npm i and you will find that you get latest versions.
|
FYI, ci is green across all the major node versions: http:https://ci.strongloop.com/job/modern-syslog/, 5 and 6 included. |
Supports nodev6