Feature/Fixed Extended User Model Support

[clockworkgr]

This should allow for full extended model support.

All relations are defined in code by PassportConfigurator and given the correct foreignKeys which are named from the extended User Model.

The foreignKey in each relation is used to set the correct property name in all references.

Unfortunately computed property name support is not in node yet so we have to do this:

         var userDataObj={
           provider: provider,
           externalId: profile.id,
           authScheme: authScheme,
           profile: profile,
           credentials: credentials,   
           created: date,
           modified: date
         };
         userDataObj[userIdentityModel.relations.user.keyFrom]= user.id;
         userIdentityModel.create(userDataObj, function (err, identity) {
....

instead of :

         userIdentityModel.create({
           provider: provider,
           externalId: profile.id,
           authScheme: authScheme,
           profile: profile,
           [userIdentityModel.relations.user.keyFrom]: user.id,
           credentials: credentials,         
           created: date,
           modified: date
         }, function (err, identity) {
....

Tests have not been rewritten for these changes

[slnode]

Can one of the admins verify this patch? To accept patch and trigger a build add comment ".ok\W+to\W+test."

[diesal11]

+1, need this functionality in the package asap

[ianseyer]

So is this present now? How do we use it?

[julien-sarazin]

+1

[ianseyer]

+1

[jonathan-casarrubias]

For those -like me- who simply can not wait until this module is merged and released, I took @clockworkgr fix, I did just small tweaks and published under loopback-component-passport-c

So thanks to @clockworkgr fix, now we can assign a specific user model. its working for me now..

$ npm uninstall --save loopback-component-passport
$ npm install --save loopback-component-passport-c

Following the standard documentation from loopback should work -now it does-, the following method does what everyone would expect it to do.

passportConfigurator.setupModels({
 userModel: app.models.Account, // Now my users are stored in Account
 userIdentityModel: app.models.AccountIdentity,
 userCredentialModel: app.models.AccountCredential
});

Please consider that passing an app.models.user as is recommended in some loopback documentation would partially work, it does not only breaks conventions rules it only works when you run inside node, when you try to access through REST interface, it will try to search for users in "User" collection and not in "user" collection, thus breaking the system... storing in lowercased name collection, and searching in uppercase name collection.. therefore this is a big concern and requires immediate solution.

For that reason I encourage anyone willing to fix this issue in your project ASAP by using loopback-component-passport-c until the moment this is fixed in the core module.

Cheers
@jonathan-casarrubias

[markstuart]

Thanks @jonathan-casarrubias, I am currently using your fork of this library with the work done by @clockworkgr with an extended User model.

Perhaps @loay would have some time to review this and hopefully merge so that those of us with extended user models don't get left behind?

[slnode]

Can one of the admins verify this patch? To accept patch and trigger a build add comment ".ok\W+to\W+test."

[enceladus]

+1. Using the fork @jonathan-casarrubias made until it's merged — working perfectly.

[slnode]

Can one of the admins verify this patch? To accept patch and trigger a build add comment ".ok\W+to\W+test."

[jonathan-casarrubias]

No problem guys, is good to help..

For more loopback packages and mixings follow me at twitter https://twitter.com/johncasarrubias I have been publishing other components for this framework that may be of your interest.

Cheers
@jonathan-casarrubias

[bennyt2]

+1 using the @jonathan-casarrubias fork and it works just as intended. I'll keep using it until it's merged. Thank you!

[slnode]

Can one of the admins verify this patch?