Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Server info oop #192

Merged
merged 30 commits into from
Jan 21, 2018
Merged

Server info oop #192

merged 30 commits into from
Jan 21, 2018

Conversation

strizhechenko
Copy link
Owner

@strizhechenko strizhechenko commented Jan 15, 2018 •
edited

TODO:

  • Make CPU rate work again
  • Fix tests
  • Refactor disk rate
  • Refactor net rate
  • Remove dependency on Rater.fold()
  • move anything about fold from Rater to subsystems classes
  • Refactor CPU read
  • Refactor CPU parse
  • Refactor other subsystems
  • Cleanup in code
  • Rewrite to use Server() with Reader() and Rater()
  • Get rid of Rater
  • Get rid of Reader
  • Get rid of cli/ServerInfo
  • Fix tests
  • Get rid of Collector (temporary)

@strizhechenko strizhechenko self-assigned this Jan 15, 2018
@strizhechenko strizhechenko added this to the 2.7.5 milestone Jan 15, 2018
@strizhechenko
Restored(server-info): server-info-rate runs where missed in tests.
91b1e0d
@strizhechenko
Refactoring(server-info): base __init__/__rate for every subsystem
c78d793 
Added: disk/net subsystems
@strizhechenko
Fixed(server-info): __rate in base class didn't worked because __, re…
2f44e2d 
…named to map()

Added: memory subsystem.
@strizhechenko
Refactoring(server-info): moved last subsystem (system) to the separa…
5194e1e 
…te class

Got rid from unused imports in rater
Mapped subsystem classes to their keys and got rid from that long if elif elif elif elif
@strizhechenko
Refactoring(server-info): all subsystem-specific parsers moved to app…
95ee548 
…ropriate subsystem class.
@strizhechenko
Refactoring(server-info): reader moved subsystem-specific data to app…
ebf30f7 
…ropriate classes
@strizhechenko
Refactoring(server-info): yaml module -> yaml_tools to avoid conflicts
3c7fff2
@strizhechenko
Refactoring(server-info): simplified any2int logic.
db82696
@strizhechenko
Refactoring(server-info): simplified any2int logic.
0bed6ee
@strizhechenko
Refactoring(server-info): parsing dmidecode output simplified
c924fa8
@strizhechenko
Refactoring(server-info): no six dependency > slightly higher memory …
551849a 
…usage in py2
@strizhechenko
Refactoring(server-info): no six dependency > slightly higher memory …
9aa50a8 
…usage in py2
@strizhechenko
Refactoring(server-info): simplified invert_dict_nesting logic.
dd4eb57
@strizhechenko
Refactoring(server-info): moved main logic from cli to Server class.
02d5e23
@strizhechenko
Refactoring(server-info): optimized imports.
2ef2ca0
@strizhechenko
Refactoring(server-info): naming in invert_dict_nesting
e8b7889
@strizhechenko
Refactoring(server-info): removed Rater class, Server rates itself.
b24403d
@strizhechenko
Refactoring(server-info): removed Reader class, Server read its data …
c82348c 
…itself.
@strizhechenko
Fixed(server-info): syntax error
e0c21a2
@strizhechenko
Refactoring(server-info): removed separate cli class, its Server's args
3833597
@strizhechenko strizhechenko merged commit 8069cb5 into master Jan 21, 2018
@strizhechenko strizhechenko deleted the server-info-oop branch January 21, 2018 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@strizhechenko strizhechenko

Labels
code quality
Projects
server-info
Awaiting triage
Milestone
2.7.5
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@strizhechenko