Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect handling of additional request parameters #850

Merged
merged 9 commits into from
Aug 3, 2022

Conversation

kamil-stripe
Copy link
Contributor

@kamil-stripe kamil-stripe commented Aug 3, 2022

Fixes #849

Fixes issue where using special parameter like api_key, idempotency_key, stripe_version, stripe_account, headers can cause a Received unknown parameter error.

Before fix:

resource = stripe.Customer.modify(
    "cus_123", metadata={"key": "value"}, email="[email protected]", idempotency_key="abc"
)

resulted in

stripe.error.InvalidRequestError: Request req_123: Received unknown parameter: idempotency_key

The code executes fine with the fix.

@pakrym-stripe pakrym-stripe changed the title Hotfix incorrect handling of additional request parameters Fix incorrect handling of additional request parameters Aug 3, 2022
@pakrym-stripe pakrym-stripe merged commit b2014e6 into master Aug 3, 2022
@remi-stripe remi-stripe deleted the kamil/request-hot-fix branch September 28, 2023 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v4.0.0 idempotency_key parameter unknown
3 participants