Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add convert_to_dict method #541

Merged
merged 1 commit into from
Mar 14, 2019
Merged

Add convert_to_dict method #541

merged 1 commit into from
Mar 14, 2019

Conversation

ob-stripe
Copy link
Contributor

r? @brandur-stripe
cc @stripe/api-libraries

Adds a stripe.util.convert_to_dict method that recursively converts StripeObject instances to dicts.

Partial fix for #219.

Copy link
Contributor

@brandur-stripe brandur-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment ask, but otherwise LGTM.

ptal @ob-stripe

stripe/util.py Show resolved Hide resolved
stripe/util.py Show resolved Hide resolved
@ob-stripe
Copy link
Contributor Author

I've added a comment as requested, as well as a docstring for the method to help advertise it. We don't use docstrings anywhere else in the library, but we probably should.

ptal @brandur-stripe

@brandur-stripe
Copy link
Contributor

Thanks OB. LGTM!

@ob-stripe ob-stripe merged commit 08d0597 into master Mar 14, 2019
@ob-stripe ob-stripe deleted the ob-fix-219 branch March 14, 2019 21:55
@ob-stripe
Copy link
Contributor Author

Released as 2.22.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants