detach method for detaching sources from customers #349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I had no idea that you could look for warnings in tests like that in Python. Nice job finding that, and great tests! LGTM. |
|
Released as 1.67.0. |
This was referenced Oct 23, 2017
This was referenced Oct 31, 2017
This was referenced Nov 7, 2017
This was referenced Nov 29, 2017
This was referenced Dec 21, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @brandur-stripe
cc @stripe/api-libraries @stan-stripe @will-stripe
Renames the
Source.deletemethod toSource.detach.detachis more descriptive of what the method actually does (i.e. detaching the source object from its customer object, not actually deleting the source object).Alias
detachtodeletewith a deprecation warning to avoid a breaking change. We should remove thedeletemethod in next major version.