Add Charges API

[abh]

No description provided.

[mrcwinn]

Any ETA on Charges API or looking for help?

[abh]

Hi –

Patches welcome! (In particular if they include tests and documentation update)

I haven't looked for a few days, but from my notes I think the API should be something like

• stripe.charges
• .create( { data, .. } ) - create a charge
• .retrieve( charge_id ) - retrieve a charge
• .refund(charge_id, amount) - refund a charge
• .list(count, offset, customer) - list charges; not sure about the list of parameters; maybe this should take an object with { count: 123, offset: 10, customer: customer_id } instead. If so then customers.list should be changed, too.

One of the things that made me pause implementing this was that I wasn't sure what the best way to return the error code / error description is when there are errors. An object instead of a string? If so then the other error handling should do that, too.

[mrcwinn]

Sounds great! Just committed changes to support Charge API.

[mrcwinn]

Fixed a couple little quirks. Was using a GET where it should be POST.

[abh]

Can you add some tests and then make a pull request?

[mrcwinn]

Yes. Will do soon.

On Tuesday, October 4, 2011 at 5:32 PM, Ask Bjørn Hansen wrote:

Can you add some tests and then make a pull request?

Reply to this email directly or view it on GitHub:
#1 (comment)

[abh]

Hi Chris,

I changed the spaces to tabs and then squash merged it in so the history is clean. I "faked" the commit coming from you so you get credit in the history. :-)

[mrcwinn]

Thanks! I'll save you that step in future commits.

On Wednesday, October 5, 2011 at 2:47 PM, Ask Bjørn Hansen wrote:

Hi Chris,

I changed the spaces to tabs and then squash merged it in so the history is clean. I "faked" the commit coming from you so you get credit in the history. :-)

Reply to this email directly or view it on GitHub:
#1 (comment)