-
Notifications
You must be signed in to change notification settings - Fork 984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add promo badge for incentives in MPE #4285
Draft
tillh-stripe
wants to merge
3
commits into
tillh/mpe-promo-badge-ui
Choose a base branch
from
tillh/ibp-incentives-ui-changes
base: tillh/mpe-promo-badge-ui
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Add promo badge for incentives in MPE #4285
tillh-stripe
wants to merge
3
commits into
tillh/mpe-promo-badge-ui
from
tillh/ibp-incentives-ui-changes
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🚨 New dead code detected in this PR: PaymentMethodTypeCollectionView.swift:90 warning: Function 'setIncentive(_:)' is unused
PaymentMethodIncentive.swift:16 warning: Initializer 'init(identifier:text:)' is unused
VerticalPaymentMethodListViewController.swift:28 warning: Property 'incentive' is assigned, but never used Please remove the dead code before merging. If this is intentional, you can bypass this check by adding the label ℹ️ If this comment appears to be left in error, double check that the flagged code is actually used and/or make sure your branch is up-to-date with |
tillh-stripe
force-pushed
the
tillh/ibp-incentives-model-changes
branch
from
November 20, 2024 12:44
e94fc93
to
39a1379
Compare
tillh-stripe
changed the title
Add promo badge in horizontal and vertical mode
Add promo badge for incentives in MPE
Nov 20, 2024
Base automatically changed from
tillh/ibp-incentives-model-changes
to
master
November 20, 2024 16:06
📸 Snapshot TestNo snapshots generated
🛸 Powered by Emerge Tools |
tillh-stripe
force-pushed
the
tillh/ibp-incentives-ui-changes
branch
2 times, most recently
from
November 20, 2024 22:21
91b5ab1
to
a501ff1
Compare
tillh-stripe
changed the base branch from
master
to
tillh/mpe-promo-badge-ui
November 20, 2024 22:22
tillh-stripe
force-pushed
the
tillh/ibp-incentives-ui-changes
branch
3 times, most recently
from
November 21, 2024 14:04
48ea3bd
to
b0d3f24
Compare
tillh-stripe
force-pushed
the
tillh/mpe-promo-badge-ui
branch
2 times, most recently
from
November 21, 2024 16:32
4630b6f
to
a224fee
Compare
tillh-stripe
force-pushed
the
tillh/mpe-promo-badge-ui
branch
from
November 21, 2024 16:32
a224fee
to
ec94824
Compare
tillh-stripe
force-pushed
the
tillh/ibp-incentives-ui-changes
branch
from
November 21, 2024 16:42
b0d3f24
to
4ff8ca8
Compare
tillh-stripe
force-pushed
the
tillh/mpe-promo-badge-ui
branch
from
November 21, 2024 20:07
378ed10
to
6d32d4a
Compare
tillh-stripe
force-pushed
the
tillh/mpe-promo-badge-ui
branch
3 times, most recently
from
November 25, 2024 22:28
b718c81
to
98bffe3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Motivation
Testing
Changelog