Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove foreman from Gemfile #336

Merged
merged 1 commit into from
Sep 1, 2014

Conversation

Koronen
Copy link
Contributor

@Koronen Koronen commented Aug 31, 2014

You should not put foreman into your Gemfile as the dependencies of a developer utility should not be able to interfere with the dependencies of your app.

ddollar/foreman#437 (comment)

Ruby users should take care not to install foreman in their project's Gemfile.

https://github.com/ddollar/foreman/blob/v0.68.0/README.md#installation

> You should not put `foreman` into your `Gemfile` as the dependencies of a
> developer utility should not be able to interfere with the dependencies of
> your app.
<ddollar/foreman#437 (comment)>

> Ruby users should take care *not* to install foreman in their project's
> `Gemfile`.
<https://github.com/ddollar/foreman/blob/v0.68.0/README.md#installation>
@swanson
Copy link
Collaborator

swanson commented Sep 1, 2014

LGTM

Koronen added a commit that referenced this pull request Sep 1, 2014
@Koronen Koronen merged commit d843829 into stringer-rss:master Sep 1, 2014
@Koronen Koronen deleted the remove-foreman-from-gemfile branch September 1, 2014 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants