#8732 Enhance KafkaBridge resource with consumer inactivity timeout and HTTP consumer/producer parts enablement #882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd HTTP consumer/producer parts enablement Signed-off-by: Steffen Karlsson <[email protected]>
steffen-karlsson
force-pushed
the
8732-enhance-kafkabridge
branch
from
40a7a35
to
b8fea43
Compare
|
@steffen-karlsson thanks for the PR. Is it ready for review then? Could you move out of "Draft"? I think there is no that much to add, right? |
|
Hello @ppatierno there is a few questions and concerns from my side in strimzi/strimzi-kafka-operator#8732 and @scholzj also left some comments here: strimzi/strimzi-kafka-operator#9820 which is related |
|
@steffen-karlsson any news on this PR now that the corresponding proposal was accepted? |
I've had a lot of things lately, expected to modify it next week. Sorry for the delay |
|
@ppatierno strimzi/strimzi-kafka-operator#9820 and this one is now ready. Apologies for the delay. |
scholzj
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enabling ENVs as part of changes in: strimzi/strimzi-kafka-operator#9820 related to changes in improvement: strimzi/strimzi-kafka-operator#8732