Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "fix: assembly load failure when building Stride based project on clean machine" #2317

Merged
merged 1 commit into from
Jun 8, 2024

Conversation

Eideren
Copy link
Collaborator

@Eideren Eideren commented Jun 8, 2024

Reverts #2308
Visual Studio solutions and Stride.ConnectionRouter fail to pack the dll as they don't have the referenced dll in their output path
https://teamcity.stride3d.net/buildConfiguration/Engine_Tests_WindowsSimple/25642?hideTestsFromDependencies=false&hideProblemsFromDependencies=false&expandBuildDeploymentsSection=false&expandBuildChangesSection=true&expandBuildProblemsSection=true

Could you look into this @azeno ?

Now naively adding a condition to this BuildOutputInPackage works but best to check if those projects actually need this dll.

@Eideren Eideren merged commit 086d952 into master Jun 8, 2024
2 checks passed
@Eideren Eideren deleted the revert-2308-azeno/issue-2232 branch June 8, 2024 12:52
@azeno
Copy link
Collaborator

azeno commented Jun 10, 2024

@Eideren See #2319

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants