-
-
Notifications
You must be signed in to change notification settings - Fork 955
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add package upgrade list #2093
Add package upgrade list #2093
Conversation
Once this gets reviewed and hopefully merged if all looks well, I would like to do a demo video using the community toolkit with stride but this error is mildly annoying for me and Im sure if I advertise it many average users would deal with the same issue. |
Maybe we should go with this solution "temporarily" (long term) till the Stride reservation is resolved and taken care of. |
I think this list will still be useful for some edge cases but you are right that Stride reservation should be put in place. There were still some packages that had Stride but were not on the same version that I found in nuget.org. https://www.nuget.org/packages/Stride.GraphX.WPF.Controls and a few more but these are some of the examples that may cause issues for adventerous nuget users. |
Co-authored-by: Nicolas Musset <[email protected]>
Xen2 sent a request for reserving the prefix over on nuget so I think it's safe to change from a whitelist to a blacklist instead; list only the specific repo under the prefix that should not be updated instead of listing those that should be. So that would be |
I changed over to an exclusion list like you said. here is the quick test I did with the changes result |
@Eideren I addded a for loop to check the |
Sorry about the delay. Yep, just swap to an array, do an ordinal string equality and we're done :) |
Not a problem at all, I think Im done with this PR now. |
Thanks ! |
PR Details
There are some cases where nugets contain "Stride." but do not follow the same release version. This adds a list that can be used to check if the package should be upgraded.
This is a replacement for #1881
below is a test I did excluding
Stride.Physics
andStride.Navigation
showing that no other packages are effected but the ones not in the array.Description
Adds a static array of valid projects and adds a couple checks for initial upgrades and sequential upgrades.
Related Issue
#2053
Types of changes
Checklist