Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Sample] Replace deprecated GetServiceAs calls #1943

Merged
merged 1 commit into from
Oct 16, 2023
Merged

[Sample] Replace deprecated GetServiceAs calls #1943

merged 1 commit into from
Oct 16, 2023

Conversation

Eideren
Copy link
Collaborator

@Eideren Eideren commented Oct 15, 2023

PR Details

See title.

Related Issue

#1938

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My change requires a change to the documentation.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@Eideren Eideren mentioned this pull request Oct 15, 2023
Closed
@Eideren Eideren merged commit 0343e19 into stride3d:master Oct 16, 2023
11 of 14 checks passed
@Eideren Eideren deleted the getserviceas branch October 16, 2023 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jklawreszuk Jklawreszuk Jklawreszuk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Eideren @Jklawreszuk