Solve editor problem with dictionary #1111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the problem dictionary with int type key can't change key in editor. Add support to dictionary editor with key type as char, bool, or other number type, and can modify key now.
xen2
reviewed
Aug 15, 2021
...itor/Stride.Core.Assets.Editor/View/TemplateProviders/DictionaryNumberKeyTemplateProvider.cs
Outdated
Show resolved
Hide resolved
Eideren
reviewed
Aug 15, 2021
...s/editor/Stride.Core.Assets.Editor/Quantum/NodePresenters/Commands/AddPrimitiveKeyCommand.cs
Outdated
Show resolved
Hide resolved
...itor/Stride.Core.Assets.Editor/View/TemplateProviders/DictionaryNumberKeyTemplateProvider.cs
Show resolved
Hide resolved
Remove unnessary annoucement
Use more generic interface to generate dictionary key and fix the bug default dictionary editor repeat add default key cause it can't be edited any more.
|
LGTM, thanks again @D3ZAX |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the problem dictionary with int type key can't change key in editor.
Add support to dictionary editor with key type as char, bool, or other number type, and can modify key now.