Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Normal map feature should have reconstruct Z enabled by default #983

Closed
johang88 opened this issue Jan 2, 2021 · 0 comments · Fixed by #1170
Closed

Normal map feature should have reconstruct Z enabled by default #983

johang88 opened this issue Jan 2, 2021 · 0 comments · Fixed by #1170
Labels
area-GameStudio area-Graphics bug Something isn't working good first issue Good for newcomers

Comments

@johang88
Copy link
Contributor

johang88 commented Jan 2, 2021

Release Type: Official Release
Platform(s): All
Describe the bug
Reconstruct Z is disabled for materials by default, this is incompatible with the default import setting for normal maps which has compression enabled.

Expected behavior
I expect these default settings to be consistent so that normal mapped materials just works without having to change any settings for default scenarios.
@johang88 johang88 added the bug Something isn't working label Jan 2, 2021
johang88 added a commit to johang88/stride that referenced this issue Oct 20, 2021
@johang88
stride3d#983 - Normal map feature enables reconstruct z by default
1687ae9
johang88 added a commit to johang88/stride that referenced this issue Oct 20, 2021
@johang88
stride3d#983 - Normal map feature enables reconstruct z by default
7a680d6
@johang88 johang88 mentioned this issue Oct 20, 2021
Merged
7 tasks
phr00t pushed a commit to phr00t/FocusEngine that referenced this issue Oct 25, 2021
@johang88 @phr00t
stride3d#983 - Normal map feature enables reconstruct z by default
f1f9cf5
phr00t added a commit to phr00t/FocusEngine that referenced this issue Oct 30, 2021
@phr00t
Revert "stride3d#983 - Normal map feature enables reconstruct z by de…
48d1dcd 
…fault"

This reverts commit f1f9cf5.
Eideren pushed a commit that referenced this issue Nov 15, 2021
@johang88
[Rendering] Normal map feature enables reconstruct z by default (#1170 …
89bcd5f 
…& #983)
johang88 added a commit to johang88/stride that referenced this issue Jul 15, 2022
@johang88
stride3d#983 Update DefaultValue attribute for IsXYNormal property
04130e3
johang88 added a commit to johang88/stride that referenced this issue Jul 15, 2022
@johang88
stride3d#983 Update DefaultValue attribute for IsXYNormal property
715dcc0
tebjan added a commit that referenced this issue Jul 15, 2022
@tebjan
Merge pull request #1454 from johang88/983_FixReconstructZDefaultValue
f094949 
#983 Update DefaultValue attribute for IsXYNormal property
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-GameStudio area-Graphics bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#983 - Normal map feature enables reconstruct z by default johang88/stride
2 participants
@johang88 @Eideren