Ensure that assert.Fail properly align its output #364
Conversation
fdfb958
to
cba8584
Compare
Previous implementation depended on tab alignment. This worked when the output was not prepended with anything, but would break if the output was prepended with further spaces (which can occur in environments like IntelliJ test runners). This commit fixes it so that the output is always aligned logically. Fixes stretchr#83
cba8584
to
ddb91ee
Compare
|
Example output before -- first output is running in IntelliJ, second directly in terminal:
Example output after -- first output is running in IntelliJ, second directly in terminal:
|
|
Note that this PR also makes it such that the "Messages" output is aligned, which is a behavior change. I believe this behavior is more conceptually correct and looks nicer, but that can be done as a separate discussion/PR if there's contention around that (whereas making sure the alignment is consistent between terminal and runner output is indisputably a bug that should be fixed). @ernesto-jimenez (or any other project maintainers), please let me know if you have any feedback. |
|
@ernesto-jimenez any feedback? This PR is getting fairly stale and would like to know whether it can move forward (or if it needs to be modified). |
|
@nmiyake finally had some time to review it. Looks good, merging it now :) |
Ensure that assert.Fail properly align its output
Previous implementation depended on tab alignment. This worked
when the output was not prepended with anything, but would break
if the output was prepended with further spaces (which can occur
in environments like IntelliJ test runners). This commit fixes it
so that the output is always aligned logically.
Fixes #83