Incorporate Kotlin 1.9 deprecations and new features #269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garyp
changed the title
garyp
force-pushed
the
garyp/kotlin-1.9-updates
branch
from
09b60cd
to
815d279
Compare
garyp
commented
Jul 4, 2024
| @@ -226,21 +218,19 @@ public open class CodeGenerator( | |||
| chunk: List<Pair<File.Field.Numbered, File.Field.OneOf?>>, | |||
| fullTypeName: String | |||
| ) { | |||
| line("fieldsList.apply {").indented { | |||
There was a problem hiding this comment.
This change only removed the fieldsList.apply { line (and accompanying indentation). The rest of the code didn't change.
`kotlin.compiler.execution.strategy` is no longer supported as a system property: https://kotlinlang.org/docs/whatsnew17.html#deprecation-of-the-kotlin-compiler-execution-strategy-system-property. Furthermore, Gradle docs now recommend running the Gradle daemon even for CI jobs. As such, might as well try running Kotlin in the Gradle daemon (the default config) and see if it works better now than it used to.
The kotlin-js gradle plugin is deprecated: https://kotlinlang.org/docs/whatsnew19.html#deprecation-of-the-kotlin-js-gradle-plugin
The old `kotlinOptions` DSL is deprecated in favor of this new API that is built on top of gradle properties.
They are exactly equivalent, but the new operator makes the intent of the code a bit clearer.
Kotlin 1.9.20 removed support for the legacy memory manager: https://kotlinlang.org/docs/whatsnew1920.html#removal-of-the-legacy-memory-manager. So we ne longer need to support it within pbandk. The new memory manager works more similarly to how Kotlin/JVM works, so we can remove a couple workarounds that were only needed for Kotlin/Native: 1. We no longer need to freeze `AtomicReference` values that will be shared between threads. 2. The `Message.Companion.descriptor` property on generated message classes can now be constructed eagerly (i.e. without using `by lazy`) without the circular references causing problems on Kotlin/Native. I also cleaned up the code slightly to use the new `buildList()` function introduced in recent Kotlin versions to build the list of field descriptors.
This is just the output of running `./gradlew generateProtos` after the recent changes to `CodeGenerator.kt`.
The full task name ends with `ToSonatypeRepository` rather than just `ToSonatype`. The previously-used task name is now ambiguous (after some of the changes made in the PR to update to Kotlin 1.9) and causes gradle to fail with this error: ``` Task 'publishIosArm64PublicationToSonatype' is ambiguous in root project 'pbandk' and its subprojects. Candidates are: 'publishIosArm64PublicationToSonatypeRepository', 'publishIosSimulatorArm64PublicationToSonatypeRepository'. ```
garyp
force-pushed
the
garyp/kotlin-1.9-updates
branch
from
85742ae
to
12d7ece
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There have been a bunch of features deprecated between Kotlin 1.5.32 and 1.9.24, as well as new features added. Any breaking changes were handled in #259. This PR updates pbandk to remove non-breaking deprecated features and adopt some of the new features. Specifically:
RequiresOptInannotationkotlin-jsto thekotlin-multiplatformgradle plugincompilerOptionsKotlin Gradle DSLuntilwith the new..<operatorIt'll probably be easiest to review this PR by looking at each commit separately since the changes are unrelated to each other. The description of each commit includes more details on each change.