AP-1351: Updating python to 3.9, moving to using wkhtmltopdf from a layer #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jason Myers <[email protected]>
JasonIamAUnixAdmin
approved these changes
Aug 25, 2022
LiterallyDad
approved these changes
Aug 25, 2022
Signed-off-by: Jason Myers <[email protected]>
Signed-off-by: Jason Myers <[email protected]>
| @@ -102,3 +102,7 @@ venv.bak/ | |||
|
|
|||
| *.zip | |||
| volume | |||
| .DS_Store | |||
| @@ -1,19 +1,35 @@ | |||
| install: | |||
| if [ ! -d dist ]; then virtualenv dist; fi | |||
| if [ ! -d dist ]; then python -m venv dist; fi | |||
There was a problem hiding this comment.
I'd love to get your thoughts on venvs at some point - i.e. why python -m venv
There was a problem hiding this comment.
I came close to flipping this to poetry. But I use python -m venv since it's shipped in every python distribution while the virtualenv package is going to be deprecated.
Signed-off-by: Jason Myers <[email protected]>
| @@ -1,2 +1,50 @@ | |||
| # strataworker-pdf | |||
| Queue based worker for generating PDFs from the Stratasan app into S3 | |||
| Queue based worker for generating PDFs from the Stratasan app into S3 | |||
LiterallyDad
approved these changes
Aug 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This upgrades python to version 3.9 (max supported for lambda by AWS) and adding a lambda layer for wkhtmltopdf.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Related PRs
Signed-off-by: Jason Myers [email protected]