rename applyResponseTagsFromQuery

strata · Mar 13, 2022 · 36acd1a · 36acd1a
1 parent cd65183
commit 36acd1a
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 6 deletions.
diff --git a/src/ResponseHelper/ResponseHelperAbstract.php b/src/ResponseHelper/ResponseHelperAbstract.php
@@ -55,7 +55,7 @@ abstract public function apply($response);
  * @param bool $setHeaders Whether to automatically set headers once tags are retrieved from query manager
  * @return ResponseTagger
  */
- public function addTagsFromQueryManager(ResponseTagger $responseTagger, QueryManager $manager, bool $setHeaders = false): ResponseTagger
+ public function applyResponseTagsFromQuery(ResponseTagger $responseTagger, QueryManager $manager, bool $setHeaders = false): ResponseTagger
  {
  foreach ($manager->getQueries() as $query) {
  if ($query->hasResponseRun() && $query->hasCacheTags()) {

diff --git a/src/ResponseHelper/ResponseHelperInterface.php b/src/ResponseHelper/ResponseHelperInterface.php
@@ -3,7 +3,6 @@
 namespace Strata\Frontend\ResponseHelper;
 
 use FOS\HttpCache\ResponseTagger;
-use FOS\HttpCache\TagHeaderFormatter\TagHeaderFormatter;
 use Strata\Data\Cache\CacheLifetime;
 use Strata\Data\Query\QueryManager;
 use Strata\Frontend\Exception\InvalidResponseHeaderValueException;
@@ -33,12 +32,12 @@ public function getHeaders(): array;
  public function apply($response);
 
  /**
- * Add cache tags to response tagger from query manager
+ * Apply cache tags to response tagger from query manager
  * @param ResponseTagger $responseTagger
  * @param QueryManager $manager
  * @return ResponseTagger
  */
- public function addTagsFromQueryManager(ResponseTagger $responseTagger, QueryManager $manager): ResponseTagger;
+ public function applyResponseTagsFromQuery(ResponseTagger $responseTagger, QueryManager $manager): ResponseTagger;
 
  /**
  * Set cache tag headers from response tagger

diff --git a/tests/ResponseHelper/Psr7ResponseHelperTest.php b/tests/ResponseHelper/Psr7ResponseHelperTest.php
@@ -97,7 +97,7 @@ public function testResponseTaggerFromQueryManager()
  $response = new Response();
  $responseTagger = new ResponseTagger();
 
- $responseTagger = $helper->addTagsFromQueryManager($responseTagger, $manager);
+ $responseTagger = $helper->applyResponseTagsFromQuery($responseTagger, $manager);
  $this->assertNotContains('test1,test2,test3,test4', $response->getHeader('X-Cache-Tags'));
 
  $helper->setHeadersFromResponseTagger($responseTagger);
@@ -112,7 +112,7 @@ public function testResponseTaggerFromQueryManager()
  $manager->add('query4', $query);
  $data = $manager->get('query3');
 
- $helper->addTagsFromQueryManager($responseTagger, $manager, true);
+ $helper->applyResponseTagsFromQuery($responseTagger, $manager, true);
  $response = $helper->apply($response);
  $this->assertContains('test1,test2,test3,test4,test5,test6', $response->getHeader('X-Cache-Tags'));
  }