Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

algorithm,memory,numeric: Improve thrust compatibility via ADL barriers #433

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

stotko
Copy link
Owner

@stotko stotko commented Sep 9, 2024

The recently introduced custom pair implementation in #425 resulted in regressions when using thrust's algorithms that have also been implemented by us, e.g. thrust::copy(...). This is caused by ADL since pair now is a member of the stdgpu namespace rather than thrust as before. Use ADL barriers to ensure that calling any algorithm from thrust will not accidentally delegate to our implementation.

Fixes #432

@stotko stotko added the bug label Sep 9, 2024
@stotko stotko added this to the 2.0.0 milestone Sep 9, 2024
Copy link

codecov bot commented Sep 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.34%. Comparing base (3333da6) to head (84386f6).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #433      +/-   ##
==========================================
- Coverage   97.38%   97.34%   -0.04%     
==========================================
  Files          32       32              
  Lines        2524     2524              
==========================================
- Hits         2458     2457       -1     
- Misses         66       67       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stotko stotko merged commit 1519a89 into master Sep 9, 2024
60 of 61 checks passed
@stotko stotko deleted the adl_barrier branch September 9, 2024 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Question aboout host copy
1 participant