Fix missing icons on react-native < 0.71 #455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@stevoland thanks! |
|
@stevoland can you check version 6.5.2 |
|
@dannyhw 6.5.2 icons fixed in my RN 0.69 project, thanks! |
hyochan
pushed a commit
to dooboolab-community/dooboo-ui
that referenced
this pull request
Apr 22, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@storybook/addon-ondevice-actions](https://storybook.js.org/) ([source](https://togithub.com/storybookjs/react-native)) | [`^5.3.23` -> `^6.0.0`](https://renovatebot.com/diffs/npm/@storybook%2faddon-ondevice-actions/5.3.23/6.5.3) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@storybook/addon-ondevice-knobs](https://togithub.com/storybookjs/react-native) | [`^5.3.26` -> `^6.0.0`](https://renovatebot.com/diffs/npm/@storybook%2faddon-ondevice-knobs/5.3.26/6.5.3) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@storybook/addon-ondevice-notes](https://togithub.com/storybookjs/react-native) | [`^5.3.26` -> `^6.0.0`](https://renovatebot.com/diffs/npm/@storybook%2faddon-ondevice-notes/5.3.26/6.5.3) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@storybook/react-native](https://storybook.js.org/) ([source](https://togithub.com/storybookjs/react-native)) | [`5.3.27` -> `6.5.3`](https://renovatebot.com/diffs/npm/@storybook%2freact-native/5.3.27/6.5.3) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@storybook/react-native-server](https://storybook.js.org/) ([source](https://togithub.com/storybookjs/react-native)) | [`5.3.23` -> `6.5.3`](https://renovatebot.com/diffs/npm/@storybook%2freact-native-server/5.3.23/6.5.3) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>storybookjs/react-native</summary> ### [`v6.5.3`](https://togithub.com/storybookjs/react-native/releases/tag/v6.5.3) [Compare Source](https://togithub.com/storybookjs/react-native/compare/v6.5.2...v6.5.3) ##### What's Changed - Enable dark mode to use a hook by [@​Jonatthu](https://togithub.com/Jonatthu) in [storybookjs/react-native#462 ##### New Contributors - [@​Jonatthu](https://togithub.com/Jonatthu) made their first contribution in [storybookjs/react-native#462 **Full Changelog**: storybookjs/react-native@v6.5.2...v6.5.3 ### [`v6.5.2`](https://togithub.com/storybookjs/react-native/releases/tag/v6.5.2) [Compare Source](https://togithub.com/storybookjs/react-native/compare/v6.5.1...v6.5.2) ##### What's Changed - Migration guide: fix minor typo in .storybook/main.js sample by [@​andrewlo](https://togithub.com/andrewlo) in [storybookjs/react-native#452 - docs: add diff colors to metreo config by [@​flexbox](https://togithub.com/flexbox) in [storybookjs/react-native#453 - docs: add hints on codeblocks to align README and MIGRATION by [@​flexbox](https://togithub.com/flexbox) in [storybookjs/react-native#456 - Fix missing icons on react-native < 0.71 by [@​stevoland](https://togithub.com/stevoland) in [storybookjs/react-native#455 ##### New Contributors - [@​andrewlo](https://togithub.com/andrewlo) made their first contribution in [storybookjs/react-native#452 - [@​flexbox](https://togithub.com/flexbox) made their first contribution in [storybookjs/react-native#453 **Full Changelog**: storybookjs/react-native@v6.5.1...v6.5.2 ### [`v6.5.1`](https://togithub.com/storybookjs/react-native/releases/tag/v6.5.1) [Compare Source](https://togithub.com/storybookjs/react-native/compare/v6.5.0...v6.5.1) Readme update for npm **Full Changelog**: storybookjs/react-native@v6.5.0...v6.5.1 ### [`v6.5.0`](https://togithub.com/storybookjs/react-native/blob/HEAD/CHANGELOG.md#v650-rc9) [Compare Source](https://togithub.com/storybookjs/react-native/compare/v5.3.23...v6.5.0) #### What's Changed - feat: rename tabs to sidebar, canvas, addons by [@​dannyhw](https://togithub.com/dannyhw) in [storybookjs/react-native#447 **Full Changelog**: storybookjs/react-native@v6.5.0-rc.8...v6.5.0-rc.9 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/dooboolab-community/dooboo-ui). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS41Ny4wIiwidXBkYXRlZEluVmVyIjoiMzUuNTcuMCJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
widthandheightwere only introduced as props onImagein react-native 0.71 (see eg docs for 0.70). Versions below this don't display the icons.What I did
Moved the dimensions to properties of the
sourcepropHow to test
Check the expo-example visually then struggle to downgrade the react-native version (I didn't manage it!)