Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add react-native to the resolver array #325

Merged
merged 2 commits into from
Feb 7, 2022
Merged

Add react-native to the resolver array #325

merged 2 commits into from
Feb 7, 2022

Conversation

gabimoncha
Copy link
Contributor

Issue: #255 resolverMainFields breaks uuid library / crypto polyfill

What I did

Thanks to @simon-nicholls comment

Add 'react-native' to the resolverMainField in metro file.

    resolverMainFields: ['sbmodern', 'react-native', 'browser', 'main'],

dannyhw
dannyhw requested changes Feb 7, 2022
View reviewed changes
Copy link
Member

@dannyhw dannyhw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution 🙇 .

It looks good and just needs a small change for the expo metro config also.

v6README.md Show resolved Hide resolved
@gabimoncha
Copy link
Contributor Author

@dannyhw done!

dannyhw
dannyhw approved these changes Feb 7, 2022
View reviewed changes
Copy link
Member

@dannyhw dannyhw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dannyhw dannyhw merged commit 8d459bd into storybookjs:next-6.0 Feb 7, 2022
@gabimoncha gabimoncha deleted the fix/node_modules_import branch February 16, 2022 19:10
@Peeeep Peeeep mentioned this pull request Feb 25, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dannyhw dannyhw dannyhw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gabimoncha @dannyhw